This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Fix for selectedAll field #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alfetopito
reviewed
Jan 19, 2022
Comment on lines
134
to
136
| if (selected.length === paidClaims.length) { | ||
| setSelectedAll(true) | ||
| } |
There was a problem hiding this comment.
Shouldn't it be updated when it's not fully selected as well?
Suggested change
| if (selected.length === paidClaims.length) { | |
| setSelectedAll(true) | |
| } | |
| setSelectedAll(selected.length === paidClaims.length) |
There was a problem hiding this comment.
No because if you unselect one option it will set selectedAll to false.
There was a problem hiding this comment.
...which is what we want 😂
anxolin
reviewed
Jan 20, 2022
There was a problem hiding this comment.
The PR works as expected, although I see a bit of a mess on the responsbilities of the components as discussed in https://gnosisinc.slack.com/archives/C025G521XQD/p1642676703117800?thread_ts=1642674739.113100&cid=C025G521XQD
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2221