This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Claim investment #2191
Merged
Claim investment #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
commented
Jan 18, 2022
| } else if (investFlowStep == 2) { | ||
| // Free claimings + selected investment oportunities | ||
| const selectedIndex = [...getIndexes(freeClaims), ...selected] | ||
| inputData = selectedIndex.reduce<EnhancedUserClaimData[]>((acc, idx: number) => { |
There was a problem hiding this comment.
i changed this into a reduce instead of a map + filter, because TS was giving me a hard time. It was thinking the array of clamings could contain undefined when i was filtering them...
reduce worked :)
There was a problem hiding this comment.
should we break apart this fn?
There was a problem hiding this comment.
u mean the reduce? we could, but not sure it would add a lot of value.
if we had time, would be nice to cleanup things a bit, cause the logic still is a bit hard to follow
|
Could you please provide a preview link? |
|
alfetopito
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Worked great!
Tested the ETH claim flow https://rinkeby.etherscan.io/tx/0x6e04ae0a69d91f1888246554aec7d478ff14caa7c7ac252092f42eedcc4342aa
This was referenced Jan 18, 2022
'Invest max positive' button sets 100% pn the progress bar when 0 tokens in the wallet balance
#2201
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR connects the claiming investment to the investment flow.
To Test