This repository was archived by the owner on Jun 24, 2022. It is now read-only.
[Claim - Approve] -> USDC #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W3stside
commented
Jan 14, 2022
| @@ -79,3 +79,9 @@ export const GNO: Record<number, Token> = { | |||
| 'Gnosis' | |||
| ), | |||
| } | |||
|
|
|||
| export const USDC_BY_CHAIN: Record<SupportedChainId, Token> = { | |||
There was a problem hiding this comment.
called USDC_BY_CHAIN because USDC is a native const used across the app in uni code.
Merged
|
alfetopito
approved these changes
Jan 14, 2022
Comment on lines
+253
to
+260
| gnoApproveData={{ | ||
| approveCallback: gnoApproveCallback, | ||
| approveState: gnoApproveState, | ||
| }} | ||
| usdcApproveData={{ | ||
| approveCallback: usdcApproveCallback, | ||
| approveState: usdcApproveState, | ||
| }} |
There was a problem hiding this comment.
This is fine for now, but I'd rather have the approval logic inside the claim component.
We don't need to have this at the index, or do we?
Also, I still think we can do a generic approval flow rather than one for usdc and one for gno always even when they are not used.
Refactor for another day I guess
There was a problem hiding this comment.
probably easier, just didnt like "mapping" components having this logic
anxolin
reviewed
Jan 14, 2022
done b7cea63 |
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2088 and #2087 and #2089 and closes #2151
Testing