Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

WIP styling investment flow. #2152

Merged
merged 6 commits into from
Jan 15, 2022
Merged

WIP styling investment flow. #2152

merged 6 commits into from
Jan 15, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • WIP styling the investment flow. But can be reviewed code wise.

biocom and others added 5 commits January 12, 2022 15:55
Use theme colors.
f2c1e4e
@fairlighteth
Update header button and misc styling. (#2129)
fef1965 
* Update header button and misc styling.

* Update header button mobile part 1. (#2132)

* Update header button mobile part 1.

* Re-structure claim button and mobile responsive. (#2137)

* Re-structure claim button and mobile responsive.

* Claim style improve 5 (#2146)

* Update

* Update

* Investing table styling start
@fairlighteth
Merge branch 'claim' into claim-styleImprove-1
b616bbf
Post merge styling.
0c52d81
WIP styling investment flow.
87fca25
@fairlighteth fairlighteth requested review from a team and removed request for a team January 14, 2022 16:54
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

alfetopito
alfetopito approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Only 2 concerns, which you are likely aware, but raising nonetheless:

The input rounding doesn't look so good IMO. The contents is too close to the border
Screen Shot 2022-01-14 at 09 15 45

Somewhat similar to the approval input, besides the contents being wrapped
Screen Shot 2022-01-14 at 09 17 13

anxolin
anxolin approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! the table is way more readable

One small question, should we delete this?
image

Or show only on mobile, since always show the Cow button

Also, another minor thing. Should this already show the right icon, or this not meant to be shown for now?

image

@anxolin
Copy link
Contributor

anxolin commented Jan 14, 2022 •
edited
Loading

Regarding the image, not sure if its related with this change @W3stside did https://github.com/gnosis/cowswap/pull/2154/files#diff-47875e4a5210f501cc2ef45a4a0732d2a471bafe31de3a245050a9c4ca207551R20

If it is, i guess is fixed :)

@fairlighteth fairlighteth changed the base branch from claim-styleImprove-1 to claim January 14, 2022 19:02
@W3stside W3stside merged commit a07c696 into claim Jan 15, 2022
@W3stside W3stside deleted the claim-styleImprove-6 branch January 15, 2022 11:03
@elena-zh
Copy link

The table looks great to me!
Agree with @alfetopito in terms if Input field.
Also, still mobile view of the table does not look good, but it seems to be not implemented yet.

@alfetopito alfetopito mentioned this pull request Jan 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fairlighteth @anxolin @elena-zh @alfetopito @W3stside