Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Change redux store on success claiming #2141

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Change redux store on success claiming #2141

merged 2 commits into from
Jan 14, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 13, 2022

Just small continuation of #2126

As promise, this one adds the mutation of the state.
If i new it would be so little, i wouldn't have done 2 PRs :)

image

Notes, as expected, the success window show 0 vCOW. I assume is because now it's consumed the opportunity. This should be fixed, but in another PR.

To Test

  1. Same as Add claim finalized middleware #2126
  2. Watch for that confeti

@anxolin anxolin requested a review from a team January 13, 2022 19:56
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but you are probably using the old contract, claiming windows are closed

Screen Shot 2022-01-13 at 13 27 28

@W3stside
Copy link
Contributor

approved

@anxolin anxolin changed the base branch from middleware-claim to develop January 14, 2022 11:03
@anxolin anxolin changed the base branch from develop to claim January 14, 2022 11:03
@anxolin anxolin force-pushed the middleware-claim-2 branch from 8334be5 to 7a29036 Compare January 14, 2022 11:05
@anxolin anxolin merged commit 75d4d33 into claim Jan 14, 2022
@alfetopito alfetopito deleted the middleware-claim-2 branch January 14, 2022 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants