This repository was archived by the owner on Jun 24, 2022. It is now read-only.
[Claim refactor] Table / InvestmentFlow / Status #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W3stside
changed the title
W3stside
commented
Jan 13, 2022
| @@ -0,0 +1,70 @@ | |||
| import { Trans } from '@lingui/macro' | |||
There was a problem hiding this comment.
Moves html code from index into this file, adds global claim state null checks
commented out is claimedAmount which is formatted incorrectly. fix incoming
W3stside
commented
Jan 13, 2022
| @@ -0,0 +1,102 @@ | |||
| import { ClaimType, useClaimState } from 'state/claim/hooks' | |||
There was a problem hiding this comment.
Moves table html code from index into this file, adds global claim state null checks
commented out is type code which i will fix in another PR - should be sdk types
W3stside
commented
Jan 13, 2022
| @@ -0,0 +1,216 @@ | |||
| import { | |||
There was a problem hiding this comment.
Moves investment html code from index into this file, adds global claim state null checks and approveState / approveCallback from claim into this file as props
no internal changes
|
alfetopito
approved these changes
Jan 13, 2022
anxolin
approved these changes
Jan 13, 2022
* hooks index: logic/sdk - set prices using Price SDK - useUserEnhancedClaimData sugar - cleanup / re-org * utils: mapTypeToPrice - maps claim types to their respective prices * types: EnhancedClaimData * Claim index: pass useEnhancedClaimData hook * ClaimsTable: pass new data and type * change back prices to previous * revert to keep base types same * fix broken claiming amount representation * remove unused map * map > switch - thanks @alfetopito * co-authored by @nenadV91
…-investment-status
W3stside
added
Auto-merge
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 refactor of #2085
Just the components and some necessary props/data