Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Hotfix 1.8.1 - Winter is gone (kind of) #2066

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Hotfix 1.8.1 - Winter is gone (kind of) #2066

merged 4 commits into from
Jan 10, 2022

Conversation

nenadV91
Copy link
Contributor

Summary

Removes the Christmas theme

  • there should be no snowfall effect
  • reverts to old logo image and also to old submit order sound

Before -> After images
Screenshot from 2022-01-10 14-38-58
Screenshot from 2022-01-10 14-38-40

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside W3stside self-requested a review January 10, 2022 15:28
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alfetopito
Copy link
Contributor

@nenadV91 one question regarding this change.

Is it supposed to go out out with the rebranding deployment? Because that's already the version 1.8.1 in RC

It would just avoid merging it to master directly

I rather consolidate all of them in a single hotfix branch/PR to avoid overwriting changes by accident

There is at least one other change to be included which is #2071

@alfetopito
Copy link
Contributor

@nenadV91 one question regarding this change.

Is it supposed to go out out with the rebranding deployment? Because that's already the version 1.8.1 in RC

It would just avoid merging it to master directly

I rather consolidate all of them in a single hotfix branch/PR to avoid overwriting changes by accident

There is at least one other change to be included which is #2071

Mati's changes have been merged into this PR, so you are ready to go :)

@alfetopito alfetopito merged commit c0f5f01 into master Jan 10, 2022
@matextrem matextrem deleted the hotfix/1.8.1 branch January 10, 2022 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants