Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

vCOW on profile #2062

Merged
merged 5 commits into from
Jan 11, 2022
Merged

vCOW on profile #2062

merged 5 commits into from
Jan 11, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Adding vCOW balance to Profile page

Simply loading the balance (if any) to replace the placeholder data
Screen Shot 2022-01-07 at 15 14 51

To Test

  1. Load the test PK on rinkeby 0x044a6c3636d0e4a7d3c3ead9f9a470efff0390f8531545c6d58018fe89f8a7a5
  2. Go to Profile page
  • It should show how many vCOWs it has.
  • Accounts with no vCOW will show 0
  • Networks where vCOW is not deployed (anything but Rinkeby) will not show the badge at all

@alfetopito alfetopito requested a review from a team January 7, 2022 23:17
@alfetopito alfetopito self-assigned this Jan 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as a charm

Our formatSmart doesn't add thousand separators?

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Just another tiny question: will the amount support localization? I mean, comma/dots separation for thousands/decimals on different locales, etc.?

@alfetopito
Copy link
Contributor Author

Works as a charm

Our formatSmart doesn't add thousand separators?

It adds if we want to.
Do we want to? I assume yes, will add it.

@alfetopito
Copy link
Contributor Author

Great!

Just another tiny question: will the amount support localization? I mean, comma/dots separation for thousands/decimals on different locales, etc.?

Same thing regarding the thousands separator. Will add it :)

@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 11, 2022
@mergify mergify bot merged commit be65cac into claim Jan 11, 2022
<Txt fs={14}>Balance</Txt>
<Txt fs={18} title={`${formatMax(vCowBalance)} vCOW`}>
<strong>
{formatSmart(vCowBalance, AMOUNT_PRECISION, { thousandSeparator: true, isLocaleAware: true }) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thanks.

Yes, I would probably make this the default for the formatter, i mean, most of the times we will want to have those

@alfetopito alfetopito deleted the vcow-on-profile branch January 18, 2022 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants