-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as a charm
Our formatSmart
doesn't add thousand separators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Just another tiny question: will the amount support localization? I mean, comma/dots separation for thousands/decimals on different locales, etc.?
It adds if we want to. |
Same thing regarding the thousands separator. Will add it :) |
553a21c
to
f5a4d09
Compare
<Txt fs={14}>Balance</Txt> | ||
<Txt fs={18} title={`${formatMax(vCowBalance)} vCOW`}> | ||
<strong> | ||
{formatSmart(vCowBalance, AMOUNT_PRECISION, { thousandSeparator: true, isLocaleAware: true }) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! thanks.
Yes, I would probably make this the default for the formatter, i mean, most of the times we will want to have those
Summary
Adding vCOW balance to Profile page
Simply loading the balance (if any) to replace the placeholder data

To Test
0x044a6c3636d0e4a7d3c3ead9f9a470efff0390f8531545c6d58018fe89f8a7a5