Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

[Claim] Profile: vCOW balance #2051

Merged
merged 11 commits into from
Jan 7, 2022
Merged

[Claim] Profile: vCOW balance #2051

merged 11 commits into from
Jan 7, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Jan 4, 2022

Summary

Fixes #2007
Dropdown will be implemented in an other PR when we have all the data ready.
image
image

Before (dark backround on both themes):
image

To Test

  1. Open the page Profile

@alongoni alongoni self-assigned this Jan 4, 2022
@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team labels Jan 4, 2022
@alongoni alongoni changed the title Profile} vCOW balance [Claim] Profile: vCOW balance Jan 4, 2022
@alongoni alongoni changed the base branch from develop to claim January 4, 2022 19:43
@alongoni alongoni marked this pull request as draft January 4, 2022 19:43
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@alongoni alongoni marked this pull request as ready for review January 5, 2022 19:32
@alongoni alongoni requested a review from matextrem January 6, 2022 14:19
@alfetopito
Copy link
Contributor

Tiny question: why the different font size on both sections?
Screen Shot 2022-01-06 at 09 15 31

Although Profile is the page name, the two sections are equivalent IMO and should have the same font size on the headers

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the font size comment, looks good to me

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, happy to merge this (or continue with the task of getting the real value and formatting the amount)

One minor concern to discuss with @michelbio is regarding the colors. I'm not sure the black background

One small thing we can do to make it look better imo is just use sth similar to what we used in the affiliate part:
image

@alongoni
Copy link
Contributor Author

alongoni commented Jan 6, 2022

Tiny question: why the different font size on both sections? Screen Shot 2022-01-06 at 09 15 31

Although Profile is the page name, the two sections are equivalent IMO and should have the same font size on the headers

Good point. I was thinking we should have a main title as we have in other sections (e.g about, faqs). But anyway we can use the same font-size in both cases.

@alfetopito
Copy link
Contributor

Looks ok to me, happy to merge this (or continue with the task of getting the real value and formatting the amount)

One minor concern to discuss with @michelbio is regarding the colors. I'm not sure the black background

One small thing we can do to make it look better imo is just use sth similar to what we used in the affiliate part: image

Indeed, we talked about this during the Protofire sync.
What we agreed on was to use the light/dark colors as a start, and iterate with Michel's input when he's back

But of course, open for feedback already

@alongoni
Copy link
Contributor Author

alongoni commented Jan 7, 2022

Looks ok to me, happy to merge this (or continue with the task of getting the real value and formatting the amount)

One minor concern to discuss with @michelbio is regarding the colors. I'm not sure the black background

One small thing we can do to make it look better imo is just use sth similar to what we used in the affiliate part: image

Hey @anxolin, thanks! Makes sense! Now we are using the same background colors than the affiliate section. It'll be changed when we have the dropdown working.
image

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 7, 2022
@mergify mergify bot merged commit 6272c54 into claim Jan 7, 2022
@alfetopito alfetopito deleted the 2007-vCOW-balance branch January 7, 2022 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire Handled by Protofire development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vCOW balance to Profile
4 participants