Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Release 1.8] Use real price strategy endpoint #2016

Merged
merged 6 commits into from
Dec 22, 2021
Merged

[Release 1.8] Use real price strategy endpoint #2016

merged 6 commits into from
Dec 22, 2021

Conversation

W3stside
Copy link
Contributor

Uses real price strategy endpoint configured on configuration branch under > strategies

Testing

  1. open console
  2. make sure COWSWAP is logged under useGetGpPriceStrategy log
  3. check networks tab and check quote endpoint is called

@W3stside W3stside requested review from alfetopito and a team December 20, 2021 12:57
@W3stside W3stside added the RELEASE Included in the release that is being closed label Dec 20, 2021
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

Hey @W3stside , is this OK to have 4 quote requests per 1 token pair?
image

@elena-zh
Copy link

Another issue: I can get hanging calculating price message after changing a token pair/an amount to trade
image
Possible steps:

  1. Select a token pair, an amount to trade
  2. Swap tokens in the fields
  3. Change a token pair OR change an amount to trade

Video: https://watch.screencastify.com/v/prfeLdAfPb9D9YVoDCG5

alfetopito
alfetopito approved these changes Dec 21, 2021
View reviewed changes
W3stside and others added 2 commits December 21, 2021 11:57
@W3stside @alfetopito
pathing fix
3fc99af 
Co-authored-by: Leandro Boscariol <[email protected]>
@W3stside @alfetopito
[Release 1.8] Use new quote endpoint for USD estimations (#2017)
cb5ca4a 
* export MAX_EPOCH const

* use resolveLast and cleanup deps

* Gp USDC price fetching fn w/fallback

* remove uwc log

* isSupportedChain > supportedChain

* export debouce time and use in price impact

* add rinkeby to satblecoin map

* don't export fn - no closure

* paths pt 2

Co-authored-by: Leandro Boscariol <[email protected]>

* error > warn

Co-authored-by: Leandro Boscariol <[email protected]>
@W3stside W3stside merged commit 74ca480 into release/1.8.0 Dec 22, 2021
@W3stside W3stside deleted the 1.8.0/gp-strategy-url branch December 22, 2021 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W3stside @elena-zh @alfetopito