Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

FAQ: Fixed some typos and did minor phrasing edits. #1966

Merged
merged 2 commits into from
Dec 6, 2021
Merged

FAQ: Fixed some typos and did minor phrasing edits. #1966

merged 2 commits into from
Dec 6, 2021

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Dec 3, 2021 •
edited
Loading

Summary

  • Corrected a few typos in FAQ.
  • Did some minor edits in some phrases.
  • Removed all apostrophes (such as "it's", "you've", etc) as I I think they look a bit too informal.

QUESTION: In Lines 382, 621, 660, we use the word offline. Should this be off-chain instead?

@W3stside
Copy link
Contributor

W3stside commented Dec 6, 2021

@harisang please add reviewers on PRs.

Thanks for making this

@W3stside W3stside added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Dec 6, 2021
@W3stside W3stside requested review from fairlighteth, nenadV91 and a team December 6, 2021 10:35
@elena-zh
Copy link

elena-zh commented Dec 6, 2021

Could I get a preview link for this PR?

@W3stside
Copy link
Contributor

W3stside commented Dec 6, 2021

CI is stuck, will attempt a force restart @elena-zh

@W3stside W3stside force-pushed the fixing_typos_in_faq branch from ce7c466 to 72ac6c9 Compare December 6, 2021 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

elena-zh
elena-zh approved these changes Dec 6, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 27dec14 into develop Dec 6, 2021
@alfetopito alfetopito deleted the fixing_typos_in_faq branch December 13, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

@elena-zh elena-zh elena-zh approved these changes

@fairlighteth fairlighteth Awaiting requested review from fairlighteth

@nenadV91 nenadV91 Awaiting requested review from nenadV91

Assignees
No one assigned
Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harisang @W3stside @elena-zh @lint-action