-
Notifications
You must be signed in to change notification settings - Fork 54
Turning on thousand separator for FIAT values #1934
Conversation
|
Hey @alfetopito , great changes! Another issue I'd like to bring up here is that now we show differently USD and token amounts: I think, we should use the same amounts formatting across the app for both tokens and USD amounts. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice, would say that Elena's comment about the non-conformity between the 2 amounts is a bit strange but not that bad. the separator looks god
Hmm, that'd be up to Javascript's locale settings, besides a special case handling for Switzerland, not much to do from our side.
Regarding that, the point is not to touch the user input field. If I recall correctly, on the confirmation modal they are formatted, just not in the swap input. One idea to not impact the actual input contents is to format it using CSS, but anyway, out of the scope of this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Happy u took the initiative to fix this.
Eventually we would need to fix the amounts as Elena says. But thats out of this one's scope.
Maybe we can schedule some work for protofire in next sprint with this.
I have added a note to implement all nicely formatted amounts into another related task #1897 (comment) |
Summary
Closes #1876
It's also locale aware.
Meaning, if your locale uses
,
as decimals separator and.
as thousand separator you'll see13.232.432,11
and so onLeft: after; Right: before

To Test
,
Background
Optional: Give background information for changes you've made, that might be difficult to explain via comments