This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tries to improve the UX around when we detect an order has been fullfileed.
This PR is a bit sensitive because changes:
However, the changes try to be scoped to only:
For reviewers
I left some commented console logs, was helpful while analysing, but i think is too much output. I left it there cause it's handy imo, but if you totally hate it, i would remove
To Test
2.Make sure cancelling orders work as expected
context
We need to make sure we detect the trades as soon as possible. Maybe we can research in hybrid approach using (time, bock, events, or a combination of the three). Related #1892