Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

[ABA 🎶 ] - base logic and new hook #1872

Closed
wants to merge 5 commits into from
Closed

[ABA 🎶 ] - base logic and new hook #1872

wants to merge 5 commits into from

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Nov 17, 2021

Summary

Part of #1495 - this PR adds the core code BEFORE actually calculating anything. Next PR will calculate the ABA impact using @anxolin 's function

TESTING

  • not applicable yet

NOTE

  1. there is an issue with ABA as lots of trades just dont have B > A liquidity...
  2. test that by going xdai and trying pairs like WXDAI <> AKRO - where the AB works, an there is no FIAT but the ABA test fails as the BA trade (AKRO > WXDAI) returns "No liquidity" meaning we cant make the aba impact

1. calculates normal USD price impact
2. calculates Aba price impact
3. new hook for getting price impact from both
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside
Copy link
Contributor Author

superseded by #1903

@W3stside W3stside closed this Nov 25, 2021
@alfetopito alfetopito deleted the aba-test branch November 25, 2021 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant