This repository was archived by the owner on Jun 24, 2022. It is now read-only.
[Profile] Add name to IPFS files + Upload JSON using pinata #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matextrem
added
Bug
|
|
nice! |
alfetopito
reviewed
Nov 16, 2021
|
Merged to Something is up with integration tests, which is unrelated to this change. Feel free to add post merge comments. |
alfetopito
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Remove ipfs-http-client and upload to ipfs using pinata sdk * Remove dep from package.json + decode the CID to get the multihash digest * Remove console.log * Update yarn.lock
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1803 #1864
Added a name to IPFS files + Removing
ipfs-http-clientlibrary and usepinatasdk to upload them due to a race condition problem.To Test
It can be tested by calling
uploadMetadataDocToIpfsand passing a metadata doc as a parameter (We could usegenerateReferralMetadataDocwith a test address).