Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

bold numbers in T&C page #1860

Merged
merged 1 commit into from
Nov 18, 2021
Merged

bold numbers in T&C page #1860

merged 1 commit into from
Nov 18, 2021

Conversation

rootial
Copy link
Contributor

@rootial rootial commented Nov 16, 2021

Summary

Bold numbers in the T&C page to make it look better as feedback from this issue

Test

  • before
    image

  • after
    image

As we can see the number is bold and looks consistent with other content

Reviewers

@anxolin @biocom

@fairlighteth fairlighteth self-requested a review November 16, 2021 17:34
@elena-zh
Copy link

Could you please provide a preview link to test the changes?

@rootial
Copy link
Contributor Author

rootial commented Nov 17, 2021

@elena-zh i test it locally, what should i do to generate a preview which you can access?

@rootial
Copy link
Contributor Author

rootial commented Nov 17, 2021

hi @biocom , can you please take a look at this PR? And how can i trigger a deploy to generate a preview for it? thanks

@elena-zh
Copy link

@rootial , I believe @anxolin , @biocom could help with this...

@alfetopito
Copy link
Contributor

I believe that due to how github is setup, external contributors won't have access to our full CI infra.
I approved the CI run but I expect it to fail.

Best way to test is setting it up locally in this case.

@rootial
Copy link
Contributor Author

rootial commented Nov 18, 2021

Hi @alfetopito , i have tested locally and please refer the screenshoot above. thanks

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changed file: Looks good to me.

@alongoni alongoni self-requested a review November 18, 2021 14:38
Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! thanks @rootial!

@rootial
Copy link
Contributor Author

rootial commented Nov 18, 2021

Hi @biocom , can you help review and merge this PR. I can't enable the CI to run from the fork repo and have no write access to commit to the develop branch directly. but i test it locally, should work. thanks~

@anxolin
Copy link
Contributor

anxolin commented Nov 18, 2021

Thanks for your contribution @rootial!

@alfetopito alfetopito merged commit 28f8173 into gnosis:develop Nov 18, 2021
@ramirotw ramirotw mentioned this pull request Dec 2, 2021
nenadV91 pushed a commit that referenced this pull request Jan 3, 2022
* Revert "feat: quick fix for new governor"
This reverts commit 5dd1249.

* support multiple governance contracts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants