-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
Could you please provide a preview link to test the changes? |
@elena-zh i test it locally, what should i do to generate a preview which you can access? |
hi @biocom , can you please take a look at this PR? And how can i trigger a deploy to generate a preview for it? thanks |
I believe that due to how github is setup, external contributors won't have access to our full CI infra. Best way to test is setting it up locally in this case. |
Hi @alfetopito , i have tested locally and please refer the screenshoot above. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changed file: Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! thanks @rootial!
Hi @biocom , can you help review and merge this PR. I can't enable the CI to run from the fork repo and have no write access to commit to the develop branch directly. but i test it locally, should work. thanks~ |
Thanks for your contribution @rootial! |
# Summary Fixes #1891 #1860 Before:  After:  # To Test 1. <<Step one>> Open the page [Terms and Conditions](https://pr1894--gpswapui.review.gnosisdev.com/#/terms-and-conditions)
* Revert "feat: quick fix for new governor" This reverts commit 5dd1249. * support multiple governance contracts
Summary
Bold numbers in the T&C page to make it look better as feedback from this issue
Test
before

after

As we can see the number is bold and looks consistent with other content
Reviewers
@anxolin @biocom