This repository was archived by the owner on Jun 24, 2022. It is now read-only.
[1798 - Fee zero/null] add zero logic for fee #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey @W3stside , could you please explain which tokens to select for testing?
|
alfetopito
reviewed
Nov 8, 2021
Co-authored-by: Leandro Boscariol <[email protected]>
anxolin
approved these changes
Nov 9, 2021
Swap conf: Swap page: |
elena-zh
approved these changes
Nov 9, 2021
|
I'm approving this based on the provided screenshots as I can't get/simulate real data to test this. |
W3stside
added a commit
that referenced
this pull request
Nov 9, 2021
* add zero logic for fee * None! >> Free! Co-authored-by: Leandro Boscariol <[email protected]> * add gap to popover and Free when 0 fee Co-authored-by: Leandro Boscariol <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1798
Fee can be zero if gas is low, fixes this. Uses
🎉 None!if fee is zero