This repository was archived by the owner on Jun 24, 2022. It is now read-only.
applied 50% width #1777
Merged
applied 50% width #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
elena-zh
suggested changes
Nov 4, 2021
There was a problem hiding this comment.
Hey @maria-vslvn , great.
But it would be ice to adjust fields better when a screen width is less than 350px.
It would be nice not to move up the 'Total traded volume' icon, center-align the label's text and decrease a line-height
Also, it would be nice to use a line break for the 'Total traded volume' text even when a screen width is a bit more than 350 px in order to avoid situation, when visually elements seems to be not center-aligned
alfetopito
approved these changes
Nov 4, 2021
elena-zh
approved these changes
Nov 5, 2021
added 2 commits
November 8, 2021 13:00
alfetopito
force-pushed
the
feature/1752-profile-fields-of-diff-width
branch
from
880a250 to
f6174a6
Compare
|
I've rebased and changed the branch to point to develop. Will merge once build finished |
alfetopito
added
Auto-merge
ramirotw
pushed a commit
that referenced
this pull request
Nov 10, 2021
# Summary Fixes #1752 Fields in sections do not have the same width. See the image:  # To Test 1. Open the page `Profile` 2. checkou items from the screenshot # Background *Optional: Give background information for changes you've made, that might be difficult to explain via comments*
ramirotw
pushed a commit
that referenced
this pull request
Nov 10, 2021
# Summary Fixes #1752 Fields in sections do not have the same width. See the image:  # To Test 1. Open the page `Profile` 2. checkou items from the screenshot # Background *Optional: Give background information for changes you've made, that might be difficult to explain via comments*
Merged
nenadV91
pushed a commit
that referenced
this pull request
Nov 15, 2021
This would allow for direct routing from UMA tokens to June expiry UMA and UNI covered call option tokens (specifically [UMA 25 Call [30 June 2021]](https://etherscan.io/address/0xb46f57e7ce3a284d74b70447ef9352b5e5df8963) and [UNI 50 Call [30 June 2021]](https://etherscan.io/address/0xe0360a9e2cdd7d03b9408c7d3001e017bac2ecd5)), in the same manner as the May expiry call tokens allowed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1752
Fields in sections do not have the same width. See the image:
To Test
ProfileBackground
Optional: Give background information for changes you've made, that might be difficult to explain via comments