Feature/1730 notif banner miss adjusts #1756
Conversation
|
There was a problem hiding this comment.
Hey @maria-vslvn , I cannot to close the banner now: the page quickly refreshes, then close button stops working.
https://watch.screencastify.com/v/H9BVgKFmzeP1QNNA3STz
There was a problem hiding this comment.
A few comments regarding the code.
Regarding the behaviour, if I dismiss one banner regarding reason x for account a, when I change to account b, reason x will not pop a banner again.
I think the banner dismiss status should be kept per account, but maybe I missed where this was decided.
Not strongly against it, just raising the point. Does anyone agree?
@alfetopito , it should work as you described: statuses states should be kept per account. |
Co-authored-by: Leandro Boscariol <[email protected]>
Co-authored-by: Leandro Boscariol <[email protected]>
|
@elena-zh @alfetopito @ramirotw please check the updates |
|
Current behavior does not look like an expected: I have created a separate issue for this #1806 |
| } | ||
|
|
||
| export const initialState: AffiliateState = { | ||
| appDataHash: APP_DATA_HASH, | ||
| isNotificationClosed: IS_NOTIFICATION_CLOSED, |
There was a problem hiding this comment.
Yes, that's the direction we want to go!
We just need 2 more dimensions: account and reason/type of notification
With the current setup, if dismissed once, the pop-up will never be displayed again for other accounts or reasons
…notif-banner-miss-adjusts
Summary
Fixes #1730
Notification banner is expected to disappear after it was closed and a page was reloaded.
To Test
To reproduce:
AR: banner appears again
ER: banner should not appear when it is closed for the current account
Need to show banner again when switch to another account