This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Fix Affiliate error banner showing up #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alfetopito
approved these changes
Nov 2, 2021
anxolin
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1749
This fixes an issue where an invalid referral banner was displayed after refreshing the page where no referral query parameter was present. Cause: An invalid referral was set in the address bar and persisted in storage, later on through navigation the referral query parameter is removed but the error banner is still showing up because the referral object was still present in storage.
To Test
ER: The error banner shouldn't appear again