-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
UNSUPPORTED_NETWORK: 'Only Mainnet is supported. Please change the network to participate', | ||
NOT_CONNECTED: 'Please connect your wallet to participate.', | ||
OWN_LINK: 'Your affiliate code works! Anyone new user following this link would credit you his trading volume.', | ||
ALREADY_TRADED: 'Invalid affiliate code: Referral only valid for new accounts.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfetopito Maybe I'm a bit confused, but is this message ok? Not sure about "Invalid affiliate code".
Also I'll need some support from @elena-zh to test all cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you confused about? Do you think the message does not reflect the behaviour?
Messages are not 100% closed, feel free to suggest something different.
I'm sure when BD people review it they will ask for adjustments anyway hehe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alfetopito. I was referring to the comment Elena made later.
a user has already traded without a referral code
a user has already traded with a referral code?
For now I made the simplest way by adding the two cases in one sentence. If we want to split the messages, I can try it (surely with some help 😅 ).
Hey @alongoni , could you please mention 'special' cases I need to help you with?
IMHO, in order not to make it complicated, it would be nice to have 1 common message something like
|
👍
On one hand, yes, both fall into the same case of "already traded".
👍 |
ACTIVE: 'Your affiliate link will be effective on next trade', | ||
UNSUPPORTED_NETWORK: 'Only Mainnet is supported. Please change the network to participate', | ||
NOT_CONNECTED: 'Please connect your wallet to participate.', | ||
OWN_LINK: 'Your affiliate code works! Anyone new user following this link would credit you his trading volume.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OWN_LINK: 'Your affiliate code works! Anyone new user following this link would credit you his trading volume.', | |
OWN_LINK: 'Your affiliate code works! Any new user following this link would credit you their trading volume.', |
NOT_CONNECTED: 'Please connect your wallet to participate.', | ||
OWN_LINK: 'Your affiliate code works! Anyone new user following this link would credit you his trading volume.', | ||
ALREADY_TRADED: 'Invalid affiliate code: Referral only valid for new accounts.', | ||
ACTIVE: 'Valid affiliate code: You can now do your first trade, to join the program.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACTIVE: 'Valid affiliate code: You can now do your first trade, to join the program.', | |
ACTIVE: 'Valid affiliate code: You can now do your first trade to join the program.', |
Changes look good to me, however, I was not able to check cases for an invalid affiliate link as validation is not yet implements (#1570). Also, I was not able to simulate an error with a failed IPFS upload. For now, I think, It would be nice to add 'try again' to the Also, it would be great to adjust test on banners in mobile views in order not to exceed the banner's area |
Hey @alongoni , notification text in banners look good to me in a mobile view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Closes #1343
Change status messages on Affiliate program.

To Test
Go to Profile page
Cases: (I Need help here to complete the steps to reproduce each case)