This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Removed default blocknative key #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will delete the key on blocknative once these changes hit prod
|
anxolin
approved these changes
Oct 7, 2021
|
@alfetopito not to self:
|
|
Didn't work missed one change #1534 |
alfetopito
added a commit
that referenced
this pull request
Oct 8, 2021
Will delete the key on blocknative once these changes hit prod Co-authored-by: Leandro Boscariol <[email protected]>
This was referenced Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed default blocknative key
Will delete the key on blocknative once these changes hit prod
Secret env variable
REACT_APP_BLOCKNATIVE_API_KEYadded to repo settingsTo Test
Not testable on PRs, as wildcard urls are not compatible with blocknative
Could be done as one-offs if needed, though.
Will be testable when deployed to https://cowswap.dev.gnosisdev.com