Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Improve dark mode color styles. #1401

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Improve dark mode color styles. #1401

merged 4 commits into from
Sep 8, 2021

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Sep 6, 2021 •
edited
Loading

Summary

Screen.Recording.2021-09-06.at.16.16.30.mov
Screen.Recording.2021-09-06.at.17.00.12.mov

@fairlighteth fairlighteth requested review from a team September 6, 2021 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Sep 6, 2021

Hey @biocom , great job!
Some minor issues from my side:

  1. In Android, when I start typing into the token search field, I get strike through 'Custom token' label. I assume it is due to keyboard raises up 'Tip' warning area. in iOS this area remains to be hidden when open the keyboard

image
image

  1. The next case is more like an enhancement: can you separate custom token Tip area in the same manner as you separated 'Manage token list' area?
    image
    image

Thanks

MareenG
MareenG approved these changes Sep 7, 2021
View reviewed changes
Copy link

@MareenG MareenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't experience the styling issues mentioned by Elena.

@fairlighteth
Copy link
Contributor Author

fairlighteth commented Sep 7, 2021 •
edited
Loading

@elena-zh Pushed some updates (wait for build)

Screen.Recording.2021-09-07.at.14.33.19.mov

calatop-black-hole-black-hole

elena-zh
elena-zh approved these changes Sep 7, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biocom , great, thank you!

@fairlighteth fairlighteth merged commit c8c9a9a into develop Sep 8, 2021
@alfetopito alfetopito deleted the 796/color-styles branch September 8, 2021 18:27
@W3stside W3stside mentioned this pull request Sep 10, 2021
Merged
W3stside pushed a commit that referenced this pull request Sep 22, 2021
@fairlighteth @W3stside
Improve dark mode color styles. (#1401)
7cf6224 
* Improve dark mode color styles.

* Improve dark mode color styles.

* Improve dark mode color styles.

* Improve dark mode color styles.
This was referenced Sep 22, 2021
Closed
Merged
anxolin pushed a commit to anxolin/cowswap that referenced this pull request Apr 1, 2022
@fairlighteth @W3stside
Improve dark mode color styles. (gnosis/cowswap#1401)
ea4f68a 
* Improve dark mode color styles.

* Improve dark mode color styles.

* Improve dark mode color styles.

* Improve dark mode color styles.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

@MareenG MareenG MareenG approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fairlighteth @elena-zh @alfetopito @anxolin @MareenG