Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Rounding issues: 'not enough funds' message is displayed when balance=investment balance #2276

Closed
elena-zh opened this issue Jan 24, 2022 · 3 comments
Closed

Rounding issues: 'not enough funds' message is displayed when balance=investment balance #2276

elena-zh opened this issue Jan 24, 2022 · 3 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

  1. Connect to a wallet
  2. Try to claim on behalf of an account
  3. Make sure you have exactly the same amount of an investment token in the connected wallet that is displayed on the form to invest

AR: 'not enough funds' message is displayed when balance=investment balance.
This is due to rounding issues, as slightly more token's balance is needed for 100% investment
image.png

image.png

ER: several options:

  • show the whole amount needed for investment
  • show the whole amounts on hover a mouse?
@elena-zh elena-zh added app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Jan 24, 2022
@elena-zh elena-zh mentioned this issue Jan 24, 2022
Merged
@elena-zh
Copy link
Author

If come up with decision to show amounts on hover, it would be nice to add it to the amounts on the next screen as well
image

@alfetopito
Copy link
Contributor

No longer applies as the native balance is no longer blocking #2279

The amounts on hover are still valid and will be added

@elena-zh
Copy link
Author

No longer applies as the native balance is no longer blocking #2279

I described the issue based on ETH, but I believe, I will face this rounding issue when I try another investment token.

maria-vslvn pushed a commit that referenced this issue Jan 25, 2022
@zzmp
chore: upgrade type system (#2276)
f5557a4 
* chore: upgrade type system

Upgrade types, typescript, and formatters.

* fix: ListsState tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfetopito @elena-zh