Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Claim: show token's account info when claim on behalf #2083

Closed
elena-zh opened this issue Jan 11, 2022 · 5 comments
Closed

Claim: show token's account info when claim on behalf #2083

elena-zh opened this issue Jan 11, 2022 · 5 comments
Labels
app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Jan 11, 2022

It would be nice to have a message 'You have successfully claimed X vCOW for an ' , in the activity modal when claim on behalf on an account.
#2083 (comment)

@elena-zh elena-zh added app:CowSwap CowSwap app Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system Claim Issues related to 'Claim' feature labels Jan 11, 2022
@anxolin
Copy link
Contributor

anxolin commented Jan 26, 2022

I think this doesn't apply anymore AFAIT

reopen if it's not the case

@anxolin anxolin closed this as completed Jan 26, 2022
@elena-zh elena-zh reopened this Jan 26, 2022
@elena-zh
Copy link
Author

Hey @anxolin , I still do not see this into in the Activity modal.
That's why I prefer leaving it opened
image

@anxolin
Copy link
Contributor

anxolin commented Jan 27, 2022

But, let me see if i get the issue correctly. You are suggesting to be more specific with the message, and instead of Claim 1.766 Cow [Executed] you would want to add something more like "You have successfully claimed..."

I believe the activity have listed operations, and they are described in a neutral way, so the message would work for [Executed] or [Pending] or [Failed]

I don't think we are personalising the message for other operations, and I would think now we wrote "Claim" instead of "Claiming" the message is clear and works for all 3 cases.

Let me know if im missing sth

@elena-zh
Copy link
Author

elena-zh commented Jan 27, 2022

@anxolin , no exactly.
I mean to separate actions in the Activity modal:

  • claim for myself: leave it as it is: Claim 1.766 Cow [Executed]
  • claim on behalf: Claim 1.766 Cow for <account>[Executed]

@anxolin
Copy link
Contributor

anxolin commented Jan 27, 2022

Ok! thanks for clarifying. The thing is, the message will be a bit long if we include the proposed one (cause the address is long).
If im not mistaken, the message currently is just a text, so we don't have an easy way to add a link and shorten the URL. Also, probably not worth it.

We can keep it open, but i think it will be not worth doing this one personally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants