Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Affiliate] combine data from /trades and /profile api queries #1819

Closed
elena-zh opened this issue Nov 11, 2021 · 1 comment · Fixed by #1900
Closed

[Affiliate] combine data from /trades and /profile api queries #1819

elena-zh opened this issue Nov 11, 2021 · 1 comment · Fixed by #1900
Assignees
@matextrem
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team

Comments

@elena-zh
Copy link

Originally reported in https://altoros.slack.com/archives/C026K00F676/p1636568152191100

I'm connected with an account that previously traded on backend-staging

image.png

When I follow an affiliate link on backend-prod, UI tells me I am qualified for affiliate, even though affiliate data clearly shows I have trades
A solution could be to combine data from /trades and /profile api queries.
@elena-zh elena-zh added app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Nov 11, 2021
@elena-zh
Copy link
Author

Another case is for error messages: I see that affiliate banner says me that I have trades, but there is an error loading data to my profile
image

@elena-zh elena-zh added the Protofire Handled by Protofire development team label Nov 12, 2021
@matextrem matextrem self-assigned this Nov 17, 2021
@elena-zh elena-zh mentioned this issue Nov 17, 2021
Merged
@alfetopito alfetopito mentioned this issue Nov 17, 2021
Closed
@matextrem matextrem mentioned this issue Nov 22, 2021
Merged
2 tasks
@matextrem matextrem mentioned this issue Feb 16, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matextrem matextrem

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge /profile and /trades api queries in order to get trades gnosis/cowswap
2 participants
@matextrem @elena-zh