Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

The icon of DAI on xDAI chain is the same the icon of ETH #1179

Closed
alfetopito opened this issue Aug 4, 2021 · 1 comment · Fixed by #2122
Closed

The icon of DAI on xDAI chain is the same the icon of ETH #1179

alfetopito opened this issue Aug 4, 2021 · 1 comment · Fixed by #2122
Assignees
@alongoni
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team

Comments

@alfetopito
Copy link
Contributor

Description

The icon of DAI on xDAI chain is the same the icon of ETH

How to Reproduce
Steps to reproduce the behavior:

  1. Go to cowswap.exchange
  2. Connect a wallet while on xDai network
  3. Pick xDai (ETH equivalent token)
  4. See error

Expected behavior
xDai should not have the ETH symbol

Screenshots

screenshot_2021-08-04_09-58-32

Additional context
Add any other context about the problem here.
Also, if it's relevant for the described byg, add information like the browser or OS.
@alfetopito alfetopito added the Bug Something isn't working label Aug 4, 2021
@elena-zh elena-zh added app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Aug 18, 2021
@elena-zh
Copy link

Need to change wxDAI logo as well: discussed in #2073 (comment)

@elena-zh elena-zh added the Protofire Handled by Protofire development team label Jan 11, 2022
@elena-zh elena-zh mentioned this issue Jan 11, 2022
Merged
@alongoni alongoni mentioned this issue Jan 12, 2022
Merged
@mergify mergify bot closed this as completed in #2122 Jan 13, 2022
mergify bot pushed a commit that referenced this issue Jan 13, 2022
@alongoni
Update xdai and wxdai token logo (#2122)
ddf8ca6 
# Summary

Fixes #1179 
Before:
![image](https://user-images.githubusercontent.com/622217/149204240-1c9f6279-d524-42e0-9269-4d60ff8a4be4.png)
After:
![image](https://user-images.githubusercontent.com/622217/149204282-281b531d-4b83-4651-8240-341e051ff770.png)


  # To Test

1. Open the page [`swap`](https://pr2122--gpswapui.review.gnosisdev.com/)
2. Connect a wallet while on xDai network
3. Pick xDai and wxDai
4. Check the token logos. Should look like the screenshot above.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alongoni alongoni

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update xdai and wxdai token logo gnosis/cowswap
3 participants
@alfetopito @alongoni @elena-zh