This repository was archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Summary Waterfalls into #2250 Show warning/error when using too much native currency to invest Uses current gas estimation for 1 approval. Might need to adjust that for a higher amount If it's a Smart contract wallet, show a warning and let user proceed. If it's an EOA wallet, show an error and block from moving forward until amount is corrected. ## Smart contract:  ## EOA:  # To Test 1. With and EOA, load one account that has a ETH investment option 2. Fund the account with not enough ETH to cover the full investment 3. On approvals page, select to invest max * You'll see the error as you are using everything in your wallet 4. With a Smart contract wallet, load one account that has a ETH investment option 5. Fund the account with exactly the amount needed to cover the full investment (this step is only need if claiming on behalf of an EOA. If you have a Safe with claims do the same as step `2`) * On approvals page, you should see the warning and be able to move forward # Background **Note:** Color is of course dumb and doesn't quite work on light more. Neither does the error color for that matter. Counting on @biocom to make it look good
- Loading branch information
1 parent
f4ae160
commit b1335dc
Showing
5 changed files
with
58 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters