-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(example/pager): Add Query Preservation to AVL Pager #3760
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
The CI is failing in lint. Could you please resolve this? Thank you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Hi, several days ago, there was a problem with the CI, and I was told to leave it for the time being. It fixed itself when merged with master in this commit: 458a825. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please write some tests that test specifically for the case you've handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit: b05cd58
Query Parameter Preservation in AVL Pager
This PR is necessary for the Hall of Fame Improvement PR which adds sorting functionality to realms. Currently, when users navigate through pages, the sort parameter is lost because the pager doesn't preserve query parameters. This enhancement ensures that sorting preferences (and other query parameters) persist during pagination.
Goal
Enhance the current Pager implementation to preserve URL query parameters when navigating between pages. The Picker function should maintain all existing query parameters while only updating the page number.
Changes
Modify the
Picker
function signature to accept the current path:Update the Picker implementation to:
Implementation Details
url.Parse
page
Development Checklist