-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnolang): prescriptively reject *ast.(IndexListExpr, GoStmt) as unrecognized for Gno #3752
base: master
Are you sure you want to change the base?
fix(gnolang): prescriptively reject *ast.(IndexListExpr, GoStmt) as unrecognized for Gno #3752
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
848e96d
to
eb973d5
Compare
Awaiting changes on #3747 |
Can you merge in master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting to remove the review team label, so it's on my radar.
d04ce70
to
9a1c5a0
Compare
Thank you @thehowl for the initial review. Kindly help me take a look again. |
9a1c5a0
to
346899a
Compare
…nrecognized for Gno The *ast.IndexListExpr is used for generics but in assignment operations it is illegal to use. This change returns a proper error and matches Go's output. Also *ast.GoStmt is for spawning Go routines but those are forbidden in Gno, hence reject them prescriptively instead of just spewing out the raw ast type. Fixes gnolang#3731 Updates gnolang#3751
346899a
to
59524ef
Compare
The *ast.IndexListExpr is used for generics but in assignment operations
it is illegal to use. This change returns a proper error and matches
Go's output.
Also *ast.GoStmt is for spawning Go routines but those are forbidden
in Gno, hence reject them prescriptively instead of just spewing
out the raw ast type.
Fixes #3731
Updates #3751