-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): remove preprocessing
variable
#3728
fix(gnovm): remove preprocessing
variable
#3728
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
preprocessing
variable
preprocessing
variablepreprocessing
variable
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. think we can also clean debugAssertSameTypes
and debugAssertEqualityTypes
(types.go), the untyped xxx staff.
I'm not sure if you refer to just removing the |
This PR removes the
preprocessing
global variable.This was only used in one function; now that we have
PreprocessingMode
in the machine, we can move this check out of the specific function and into the places where we need to check it