Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): remove preprocessing variable #3728

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 11, 2025

This PR removes the preprocessing global variable.

This was only used in one function; now that we have PreprocessingMode in the machine, we can move this check out of the specific function and into the places where we need to check it

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 11, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 11, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@thehowl thehowl added this to the 🚀 Mainnet beta launch milestone Feb 18, 2025
@thehowl thehowl changed the title fix: remove untyped bools at runtime fix: remove preprocessing variable Feb 20, 2025
@thehowl thehowl changed the title fix: remove preprocessing variable fix(gnovm): remove preprocessing variable Feb 20, 2025
@thehowl thehowl marked this pull request as ready for review February 20, 2025 19:29
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/op_decl.go 41.17% 8 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/op_assign.go 0.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. think we can also clean debugAssertSameTypes and debugAssertEqualityTypes(types.go), the untyped xxx staff.

@thehowl
Copy link
Member Author

thehowl commented Feb 24, 2025

LGTM. think we can also clean debugAssertSameTypes and debugAssertEqualityTypes(types.go), the untyped xxx staff.

I'm not sure if you refer to just removing the isUntyped func calls, but seeing as these are meant to be sanity methods to activate during debug I think it may make sense to keep 'em. I'll let you remove them in another PR if you think it should be done

@thehowl thehowl merged commit 6803b77 into gnolang:master Feb 24, 2025
54 checks passed
@thehowl thehowl deleted the dev/morgan/remove-preprocessing branch February 24, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

3 participants