feat: Add NFT Event Ticketing System #3509

JJOptimist · 2025-01-14T11:30:23Z

This PR adds a NFT-based event ticketing system.

Create events with configurable parameters (name, description, date, max tickets, price)
Purchase tickets using GNOT
Tickets are minted as NFTs using GRC721
View all events and ticket availability through web interface

Dependencies:

gno.land/p/demo/avl
gno.land/p/demo/grc/grc721
gno.land/p/demo/ufmt

The system demonstrates:

Using AVL trees for state management
Integration with GRC721 for NFT functionality
Handling GNOT payments
Web rendering with markdown formatting

Gno2D2 · 2025-01-14T11:31:25Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details (checked by @thehowl)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: JJOptimist/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

leohhhn · 2025-01-14T11:44:30Z

Hey, check out this issue, it might be interesting: #3482

This is something that is will be a priority for the Gno team and you might be able to help.

leohhhn · 2025-01-14T11:46:13Z

Also, seems you also added your home realm in this PR, which I assume was a mistake.

Please check the CI and see why it's failing :)

JJOptimist · 2025-01-14T11:54:17Z

Also, seems you also added your home realm in this PR, which I assume was a mistake.

Please check the CI and see why it's failing :)

(Tried to sneak it in) Yes beginner's mistake, the branch I created already contained my home and I forgot to remove it from the cache before pushing. Ill check the reason why its failing now

JJOptimist · 2025-01-14T11:55:23Z

Hey, check out this issue, it might be interesting: #3482

This is something that is will be a priority for the Gno team and you might be able to help.

Thanks for pointing it , I'll look into in

JJOptimist · 2025-01-14T14:08:18Z

Updated NFT ownership check to properly handle errors
Added grc721 import for proper TokenID handling

leohhhn · 2025-01-14T21:26:30Z

Check the CI jobs and their outputs; they'll tell you why they're red

codecov · 2025-01-22T12:04:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

n2p5

Could you remove the whitespace formatting changes from this PR in gnovm/* ? They are a bit distracting from the realm code for this review.

JJOptimist · 2025-01-25T20:38:44Z

Could you remove the whitespace formatting changes from this PR in gnovm/* ? They are a bit distracting from the realm code for this review.

Sorry for unnecessary mess, I ran accidentally tidy and fmt on whole repo instead of my folder

leohhhn

Hey, this looks cool, but there are some things that should be changed/improved. Please take a look at the comments 🙏

examples/gno.land/r/jjoptimist/eventix/eventix.gno

leohhhn · 2025-02-11T09:59:10Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+}
+
+func CreateEvent(name, description string, dateStr string, maxTickets int, price uint64) uint64 {
+


random newline

leohhhn · 2025-02-11T09:59:38Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+	events = avl.NewTree()
+}
+
+func CreateEvent(name, description string, dateStr string, maxTickets int, price uint64) uint64 {


seems the first three args are strings, you can shorten this

examples/gno.land/r/jjoptimist/eventix/eventix.gno

leohhhn · 2025-02-11T10:05:33Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+	amount := sent.AmountOf("ugnot")
+	if amount != int64(event.price) {
+		panic(ufmt.Sprintf("Please send exactly %d ugnot", event.price))
+	}


What do you think about making it possible to pay with any GRC20 token as well? Ie, the event creator could specify how many tokens would be needed for a ticket.

The CreateEvent function now accepts a paymentToken parameter, and BuyTicket validates the payment by checking for that token denomination.

leohhhn · 2025-02-11T10:06:18Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+	tickets.Mint(caller, tokenId)
+
+	event.ticketsSold++
+	setEvent(eventId, event)


would be good to emit events here and in other functions, ie std.Emit

I’ve added std.Emit calls in key places (e.g., after event creation and ticket purchase)

leohhhn · 2025-02-11T10:06:28Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+	setEvent(eventId, event)
+}
+
+// all events and ticket info


This is not godoc

Removed unnecessary and not formatted comments

leohhhn · 2025-02-11T10:07:36Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+func Render(path string) string {
+	output := "# Event Ticketing System\n\n"
+
+	events.Iterate("", "", func(key string, value interface{}) bool {
+		id, _ := strconv.ParseUint(key, 10, 64)
+		event := value.(Event)
+
+		output += ufmt.Sprintf("## Event #%d: %s\n", id, event.name)
+		output += ufmt.Sprintf("Description: %s\n", event.description)
+		output += ufmt.Sprintf("Date: %s\n", event.date.Format("2006-01-02 15:04:05"))
+		output += ufmt.Sprintf("Tickets: %d/%d\n", event.ticketsSold, event.maxTickets)
+		output += ufmt.Sprintf("Price: %d ugnot\n\n", event.price)
+
+		if event.ticketsSold < event.maxTickets {
+			output += ufmt.Sprintf("[Buy Ticket](/r/jjoptimist/eventix/BuyTicket?eventId=%d)\n", id)
+		} else {
+			output += "**SOLD OUT**\n"
+		}
+		output += "---\n\n"
+		return false
+	})
+
+	return output
+}


Let's use p/demo/avl/pager here

I have switched to using p/demo/avl/pager in the Render function as suggested.

leohhhn · 2025-02-11T10:08:57Z

examples/gno.land/r/jjoptimist/eventix/eventix_test.gno

+	if eventId != 1 {
+		t.Errorf("Expected first event ID to be 1, got %d", eventId)
+	}
+
+	event, exists := getEvent(eventId)
+	if !exists {
+		t.Error("Event was not created")
+	}
+
+	if event.name != "Test Event" {
+		t.Errorf("Expected event name 'Test Event', got '%s'", event.name)
+	}
+
+	// Test invalid date format
+	defer func() {
+		if r := recover(); r == nil {
+			t.Error("Expected panic with invalid date format")
+		}
+	}()
+	CreateEvent("Test", "Test", "invalid-date", 100, 1000000)
+}


Let's use uassert & urequire. Please read up on how assert & require work in go, and check out the two packages I mentioned to see how they match

I’ve updated the tests to use uassert and urequire for assertions,

leohhhn

Hey, left a few more comments that need to be resolved before merging. Seeing all the conversions you're doing with the ID, just switch to seqid; it will give you sorting by creation time by default and you won't have to do conversions so often.

Also seems the fmt & tests are failing

leohhhn · 2025-02-21T10:57:02Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+var (
+	events       = avl.NewTree()
+	eventCounter uint64 = 0
+	tickets      = grc721.NewBasicNFT("Event Ticket", "EVTIX")
+)


Run gno fmt on the package

leohhhn · 2025-02-21T10:57:58Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+	date        time.Time
+	maxTickets  int
+	price       uint64 // price per ticket (in tokens)
+	paymentToken string  // payment token symbol (e.g., ugnot or any GRC20 token)


GRC20s don't work this way; your current implementation handles only native coins. After updating the code, please add a test to validate it 🙏

leohhhn · 2025-02-21T10:58:08Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+}
+
+func CreateEvent(name, description string, dateStr string, maxTickets int, price uint64) uint64 {
+


leohhhn · 2025-02-21T11:01:31Z

examples/gno.land/r/jjoptimist/eventix/eventix.gno

+		}
+	}
+
+	pg := pager.NewPager(events, 10, true).GetPage(page)


Try using pager.MustGetPageByPath()

jjoptimist fixed what was required.

…add-eventix

leohhhn · 2025-02-26T09:49:38Z

Seems like CI is still failing

JJOptimist · 2025-02-26T09:54:18Z

Seems like CI is still failing

Yes i fixed most of the things and got the tests running properly but i didn't merge the main for some time. Looks like i need to do changes stated here

leohhhn · 2025-03-11T18:13:01Z

@JJOptimist can you fix the CI and we can merge?

JJOptimist and others added 5 commits December 25, 2024 13:03

feat: add JJOptimist's Homerealm

f76c480

Merge branch 'gnolang:master' into master

b755bc7

feat: added usage of ownable and art

d7fec48

chore: remove mykey_backup.armor

6746b48

r/jjoptimist/eventix: Add NFT event ticketing system

4770b22

github-actions bot assigned JJOptimist Jan 14, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 14, 2025

JJOptimist and others added 2 commits January 14, 2025 14:59

remove: home realm files from PR

8d5ad43

Merge branch 'master' into add-eventix

fa546b3

JJOptimist mentioned this pull request Jan 15, 2025

JJOptimist's Builder Journey gnolang/hackerspace#101

Open

notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 15, 2025

Kouteki requested a review from leohhhn January 17, 2025 12:10

JJOptimist and others added 3 commits January 17, 2025 19:06

fix: removed depricated word

900186c

Merge branch 'master' into add-eventix

1114dca

Update gno.mod

1cb4241

github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Jan 21, 2025

michelleellen requested a review from n2p5 January 22, 2025 12:02

n2p5 previously requested changes Jan 23, 2025

View reviewed changes

Gno2D2 requested a review from a team January 25, 2025 20:26

Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 25, 2025

JJOptimist force-pushed the add-eventix branch from 107b8e9 to 1cb4241 Compare January 25, 2025 20:34

fix: removed newlines again after reverting to status before

cdc4c55

JJOptimist and others added 2 commits January 29, 2025 13:04

chore(eventix): fmt & tidy

42763f0

Merge branch 'master' into add-eventix

c358938

leohhhn requested changes Feb 11, 2025

View reviewed changes

JJOptimist added 11 commits February 11, 2025 12:15

fix(eventix): initialize events in var block

758600a

fix(eventix): Increment counter after setting the event

0eaaa87

feat(eventix): Emit event after ticket purchase

371f7d8

fix(eventix): Switched to RFC3339 for date format

75be417

feat(eventix): Use strconv.Itoa for Event IDs

4e39833

chore(eventix): Updated other parts to use strconv.Itoa

89c7099

fix(eventix): Remove setEvent and Inline its Usage in BuyTicket

4e90e13

feat(eventix): Support for GRC20 tokens

537b32f

feat(eventix): Emit event creation

d26f844

feat(eventix): Added usage of pager pkg

47b9612

feat(eventix): Switched to uassert & urequire in tests

7813091

leohhhn approved these changes Feb 21, 2025

View reviewed changes

JJOptimist and others added 5 commits February 25, 2025 19:46

fix: GRC20 token payments and NFT token IDs

4c81209

feat: using MustGetPageByPath()

5701319

Merge branch 'master' into add-eventix

eaf4987

chore: fmt & tidy

9de9d74

Merge branch 'add-eventix' of https://github.com/JJOptimist/gno into …

818967d

…add-eventix

Merge branch 'master' into add-eventix

c400b34

		}

		func CreateEvent(name, description string, dateStr string, maxTickets int, price uint64) uint64 {

feat: Add NFT Event Ticketing System #3509

Are you sure you want to change the base?

feat: Add NFT Event Ticketing System #3509

Conversation

JJOptimist commented Jan 14, 2025 • edited Loading

Gno2D2 commented Jan 14, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

leohhhn commented Jan 14, 2025 • edited Loading

leohhhn commented Jan 14, 2025

JJOptimist commented Jan 14, 2025

JJOptimist commented Jan 14, 2025

JJOptimist commented Jan 14, 2025

leohhhn commented Jan 14, 2025

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

n2p5 left a comment

Choose a reason for hiding this comment

JJOptimist commented Jan 25, 2025

leohhhn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn commented Feb 26, 2025

JJOptimist commented Feb 26, 2025

leohhhn commented Mar 11, 2025

JJOptimist commented Jan 14, 2025 •

edited

Loading

Gno2D2 commented Jan 14, 2025 •

edited

Loading

leohhhn commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

leohhhn left a comment •

edited

Loading