Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make codecov only care about newlines #3277

Merged
merged 4 commits into from
Feb 6, 2025
Merged

chore: make codecov only care about newlines #3277

merged 4 commits into from
Feb 6, 2025

Conversation

moul
Copy link
Member

@moul moul commented Dec 5, 2024

CleanShot 2024-12-05 at 17 01 41

RFC

@zivkovicmilos zivkovicmilos self-requested a review December 5, 2024 16:00
@moul moul requested review from thehowl and n2p5 December 5, 2024 16:00
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 5, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul requested review from ajnavarro and Kouteki December 5, 2024 16:00
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@aeddi
Copy link
Contributor

aeddi commented Dec 5, 2024

BTW @moul did you see this comment? #3238 (comment)

TL;DR: Codecov prevents the stale bot from doing its job correctly because:

  • the stale bot adds a stale label to an inactive PR
  • Codecov is triggered by the label addition and updates its report comment even if there is no change
  • the comment edition produces activity on the PR and makes the stale bot remove the stale label

@n2p5
Copy link
Contributor

n2p5 commented Jan 23, 2025

I believe this is no longer relevant. @moul should we close?

@moul
Copy link
Member Author

moul commented Jan 30, 2025

@n2p5 I believe it is: #3578 (comment)

@n2p5 n2p5 closed this Jan 30, 2025
@n2p5 n2p5 reopened this Jan 30, 2025
@Kouteki Kouteki removed the in focus label Feb 3, 2025
Copy link
Contributor

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it

@thehowl thehowl merged commit a01a030 into master Feb 6, 2025
8 checks passed
@thehowl thehowl deleted the moul-patch-6 branch February 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants