Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gnokey url #1470

Merged
merged 1 commit into from
Dec 21, 2023
Merged

docs: update gnokey url #1470

merged 1 commit into from
Dec 21, 2023

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Dec 20, 2023

This pull request updates the URL for the gnokey documentation in the realm_help.html file. The previous URL was pointing to GITHUB which doesn't help.

The new URL directs users to the correct documentation on how to work with key pairs in the gnokey tool.

Screenshot 2023-12-20 at 00 01 58
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@iuricmp iuricmp requested a review from a team as a code owner December 20, 2023 00:08
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26fb75b) 56.13% compared to head (52ce998) 55.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   56.13%   55.87%   -0.26%     
==========================================
  Files         431      430       -1     
  Lines       65860    65618     -242     
==========================================
- Hits        36971    36667     -304     
- Misses      26005    26083      +78     
+ Partials     2884     2868      -16     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuricmp iuricmp changed the title Update gnokey docs URL docs: update gnokey url Dec 20, 2023
@thehowl
Copy link
Member

thehowl commented Dec 21, 2023

Better than before, so merging, but I'll add an issue to replace all "bad docs links" with the final docs.gno.land.

@thehowl thehowl merged commit 183d7d4 into gnolang:master Dec 21, 2023
180 of 183 checks passed
@iuricmp iuricmp deleted the chore/gnokey-list branch December 21, 2023 12:56
gfanton pushed a commit to moul/gno that referenced this pull request Jan 18, 2024
This pull request updates the URL for the gnokey documentation in the
realm_help.html file. The previous URL was pointing to GITHUB which
doesn't help.

The new URL directs users to the correct documentation on how to work
with key pairs in the gnokey tool.

<img width="1077" alt="Screenshot 2023-12-20 at 00 01 58"
src="https://github.com/gnolang/gno/assets/689440/d9f0deed-9e41-4b80-8abb-b9a3aae5f9db">


<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants