Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the update of archive policy back window #1278

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Enable the update of archive policy back window #1278

merged 3 commits into from
Jan 22, 2023

Conversation

rafaelweingartner
Copy link
Contributor

No description provided.

@rafaelweingartner
Copy link
Contributor Author

Errors are not related to the PR

@rafaelweingartner
Copy link
Contributor Author

This PR depends on the merge of #1279

@rafaelweingartner rafaelweingartner force-pushed the allow-updating-backwindow-upstream branch from f582a58 to a7fc8d9 Compare December 30, 2022 11:47
@tobias-urdin
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

rebase

✅ Branch has been successfully rebased

@chungg chungg force-pushed the allow-updating-backwindow-upstream branch from a7fc8d9 to 4b883f9 Compare January 20, 2023 00:29
tobias-urdin
tobias-urdin previously requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@tobias-urdin tobias-urdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be OK merging this in master but it need to update some testing and documentation as well. Also added a two comments that would be good to adress to prevent possible KeyError's.

gnocchi/indexer/sqlalchemy.py Show resolved Hide resolved
gnocchi/rest/api.py Show resolved Hide resolved
@mergify mergify bot dismissed tobias-urdin’s stale review January 20, 2023 16:35

Pull request has been modified.

@rafaelweingartner
Copy link
Contributor Author

@tobias-urdin thanks for the review. I added tests and documentation as you requested.

@rafaelweingartner rafaelweingartner force-pushed the allow-updating-backwindow-upstream branch from f73fb10 to 80f49d1 Compare January 20, 2023 17:51
@rafaelweingartner rafaelweingartner force-pushed the allow-updating-backwindow-upstream branch from 80f49d1 to 379232f Compare January 20, 2023 17:54
@mergify mergify bot merged commit 1d0770d into gnocchixyz:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-urdin tobias-urdin tobias-urdin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelweingartner @tobias-urdin