-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch Redis server errors #1119
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3ddee4f
Catch Redis server errors
mrunge 5353276
Move redis to install dependencies
mrunge 841287a
decorate function and skip other exception
mrunge c27ba76
Remove left over variables in excepts
mrunge 79e2363
Move all exception handling to incoming/redis
mrunge e507e41
Remove empty line added in previous commit
mrunge 7677b1c
Remove s3 and try to enable ceph again
mrunge 8fc147f
Catch exception in another place
mrunge df18070
Turn back testing to s3 and address review feedback
mrunge d6fb9e8
Drop debug output
mrunge c2e6fd0
Add stop condition and fix comment
mrunge 08a1974
Merge branch 'master' into redis_reconnect
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move redis to install dependencies
- Loading branch information
commit 5353276fe817669c8cb5a0384f5ba4142151dd63
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redis is not mandatory to run gnocchi, do not make that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Moving the change to the incoming redis driver should not make it a requirement here. I've moved it back to the redis section.