Add stop condition and fix comment

gnocchixyz · Feb 22, 2021 · df55ac6 · df55ac6
1 parent 1f3b15a
commit df55ac6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/gnocchi/incoming/redis.py b/gnocchi/incoming/redis.py
@@ -96,9 +96,10 @@ def add_measures_batch(self, metrics_and_measures):
                 notified_sacks.add(sack_name)
         pipe.execute()
 
+    # if ConnectionError exception occurs, try again, max 5 times.
     @tenacity.retry(
         wait=utils.wait_exponential,
-        # Never retry except when explicitly asked by raising TryAgain
+        stop=tenacity.stop_after_attempt(5),
         retry=tenacity.retry_if_exception_type(ConnectionError))
     def _build_report(self, details):
         report_vars = {'measures': 0, 'metric_details': {}}
@@ -183,9 +184,10 @@ def process_measures_for_sack(self, sack):
             pipe.ltrim(key, item_len + 1, -1)
         pipe.execute()
 
+    # if ConnectionError exception occurs, try again, max 5 times.
     @tenacity.retry(
         wait=utils.wait_exponential,
-        # Never retry except when explicitly asked by raising TryAgain
+        stop=tenacity.stop_after_attempt(5),
         retry=tenacity.retry_if_exception_type(ConnectionError))
     def iter_on_sacks_to_process(self):
         self._client.config_set("notify-keyspace-events", "K$")