Merge pull request #1259 from art-vasilyev/rateofchangesec-operator

Added rateofchangesec operator to calculate change of value per second
gnocchixyz · Jun 27, 2022 · b83c4a8 · b83c4a8
2 parents 39d48dd + 980b691
commit b83c4a8
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 1 deletion.
diff --git a/gnocchi/rest/aggregates/operations.py b/gnocchi/rest/aggregates/operations.py
@@ -119,8 +119,20 @@ def _inner_rated_agg(values, axis):
 }
 
 
+def rateofchangesec(t, v):
+    """Calculate change of value per second."""
+    values = numpy.divide(
+        numpy.diff(v.T, prepend=numpy.NaN),
+        numpy.divide(
+            numpy.diff(t, prepend=numpy.datetime64("NaT")),
+            numpy.timedelta64(1, 's'))
+    ).T
+    return t, values
+
+
 unary_operators_with_timestamps = {
-    u"rateofchange": lambda t, v: (t[1:], numpy.diff(v.T).T)
+    u"rateofchange": lambda t, v: (t[1:], numpy.diff(v.T).T),
+    u"rateofchangesec": rateofchangesec,
 }
 
 

diff --git a/gnocchi/tests/test_aggregates.py b/gnocchi/tests/test_aggregates.py
@@ -1642,3 +1642,32 @@ def test_unary_operator(self):
                           numpy.timedelta64(1, 'h'), 4),
                          ]}
         }, values)
+
+    def test_rateofchangesec_operator(self):
+        self.incoming.add_measures(self.metric.id, [
+            incoming.Measure(datetime64(2014, 1, 1, 12, 0, 1), 0),
+            incoming.Measure(datetime64(2014, 1, 1, 12, 5, 10), 450),
+            incoming.Measure(datetime64(2014, 1, 1, 12, 10, 5), 900),
+            incoming.Measure(datetime64(2014, 1, 1, 12, 15, 30), 1350),
+        ])
+        self.trigger_processing([self.metric])
+
+        values = processor.get_measures(
+            self.storage,
+            [processor.MetricReference(self.metric, "mean")],
+            ["rateofchangesec", ["metric", str(self.metric.id), "mean"]],
+            granularities=[numpy.timedelta64(5, 'm')],
+        )
+
+        self.assertEqual({
+            str(self.metric.id): {
+                "mean": [(datetime64(2014, 1, 1, 12, 0, 0),
+                          numpy.timedelta64(5, 'm'), eq_nan),
+                         (datetime64(2014, 1, 1, 12, 5, 0),
+                          numpy.timedelta64(5, 'm'), 1.5),
+                         (datetime64(2014, 1, 1, 12, 10, 0),
+                          numpy.timedelta64(5, 'm'), 1.5),
+                         (datetime64(2014, 1, 1, 12, 15, 0),
+                          numpy.timedelta64(5, 'm'), 1.5),
+                         ]}
+        }, values)
diff --git a/releasenotes/notes/add-rateofchangesec-operator-a24327764a6cb18d.yaml b/releasenotes/notes/add-rateofchangesec-operator-a24327764a6cb18d.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    Added ``rateofchangesec`` operator to calculate changes between metric measures per second.
+    Example: ``(* (/ (rateofchangesec (metric cpu mean)) 1000000000) 100))``