Bug fixes for empty port list in module/interface and triple quoted string support

[yuhaos]

Hi Gmlarumbe,

This patch is for the following two issues, may you please have a review? I upload grammar.js only.

• fix the issues the empty port list is not regonized
• the original implementation could not detected triple quoted string correctly, fix it.

Regards
Yuhao

The test code is quite simple:

module top();

initial begin
  string a = """
  a, b, c, "xy"
  """;
  $display("good");
end

endmodule

[gmlarumbe]

Hi @yuhaos ,

Thanks a lot for your PR.

A few comments:

• I might be missing something but the empty port list should be supported without the PR changes.

  • Check the following test files that are passing CI:
    • test/files/core/module/empty_1.sv
    • test/files/core/module/param_empty.sv
  • The optional wrapping commaSep should not be needed either since commaSep matches 0 or more comma separated values. commaSep calls sepBy which in turn includes optional already.
  • This piece of code gives me no errors:

    module top();
    endmodule

• The changes to support the triple_quoted_string look good to me. Thanks a lot for taking the time to debug these.

• Regarding the renaming from verilog to systemverilog that is something that probably could be done in a separate PR to account for the generated files.

Could you please check these points and rebase/force_push before merging? Could you also include only the grammar.js changes for triple_quoted_string and triple_quoted_string_itemin the PR?

Thanks!

[yuhaos]

Hi @gmlarumbe ,

Thanks for the explanation, the empty port list is supported in the original implementation, my change is redundant.
I re-submit grammar.js, may you have a review? Thanks.

Regards
Yuhao

[gmlarumbe]

Thanks a lot for your contribution! :)