Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexSignature decorated with readonly should not generate a setter #136

Closed
MangelMaxime opened this issue Oct 24, 2024 · 0 comments
Closed

IndexSignature decorated with readonly should not generate a setter #136

MangelMaxime opened this issue Oct 24, 2024 · 0 comments
Labels
area:converter syntax support

Comments

@MangelMaxime
Copy link
Contributor

Issue created from Glutinum Tool

Glutinum version - 0.11.0-preview

TypeScript

export interface MyType {
    readonly [n: number]: string;
}

FSharp

module rec Glutinum

open Fable.Core
open Fable.Core.JsInterop
open System

[<AllowNullLiteral>]
[<Interface>]
type MyType =
    [<EmitIndexer>]
    abstract member Item: n: float -> string with get, set

Problem description

Should generate

[<AllowNullLiteral>]
[<Interface>]
type MyType =
    [<EmitIndexer>]
    abstract member Item: n: float -> string with get
MangelMaxime added a commit that referenced this issue Oct 31, 2024
@MangelMaxime
fix: IndexSignature decorated with readonly should not generate a…
5cb91ef 
… `setter`

[converter]

=== changelog ===
```ts
export interface MyType {
    readonly [n: number]: string;
}
```

```fs
[<AllowNullLiteral>]
[<Interface>]
type MyType =
    [<EmitIndexer>]
    abstract member Item: n: float -> string with get
```
=== changelog ===

Fix #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:converter syntax support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MangelMaxime