Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logDir dyn support in gluster-block and tcmu-runner #199

Closed
lxbsz opened this issue Apr 3, 2019 · 2 comments
Closed

Add logDir dyn support in gluster-block and tcmu-runner #199

lxbsz opened this issue Apr 3, 2019 · 2 comments

Comments

@lxbsz
Copy link
Collaborator

lxbsz commented Apr 3, 2019 •
edited
Loading

This is missed currently, will add this later.

Kind of issue

Feature request

Observed behavior

The log directory path is not configurable through the /etc/sysconfig/gluster-block config file.

Expected/desired behavior

The logDir is configurable and will change without restarting the gluster-blockd service.

Details on how to reproduce (minimal and precise)

Currently the dyn config has been support, and we will add dyn-logDir base this.

Logs and Information about the environment:

Other useful information
@lxbsz lxbsz mentioned this issue Apr 3, 2019
Merged
@pkalever
Copy link
Contributor

pkalever commented Apr 3, 2019

@lxbsz should we use the ISSUE/FEATURE template, so that it make much sense for others ?

Thanks!

@lxbsz
Copy link
Collaborator Author

lxbsz commented Apr 3, 2019

Make sense and I will check this.
Thanks.

lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 3, 2019
@lxbsz
config: logDir add dyn support
90b718e 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 3, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
0f7e9fb 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 24, 2019
@lxbsz
config: logDir add dyn support
5328d58 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 24, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
d430ac3 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 25, 2019
@lxbsz
config: logDir add dyn support
be73744 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 25, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
c1218f8 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
config: logDir add dyn support
c91a75a 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
5199210 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
3c231e1 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
6c43f22 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
39e93ae 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
948968d 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
config: logDir add dyn support
e4477ea 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
Reviewed-by: Prasanna Kumar Kalever <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
9d0fa47 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
Reviewed-by: Prasanna Kumar Kalever <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
config: logDir add dyn support
f578465 
This will add the dyn logDir support based the dyn-config without
restarting the gluster-blockd service.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
Reviewed-by: Prasanna Kumar Kalever <[email protected]>
lxbsz added a commit to lxbsz/gluster-block that referenced this issue Apr 26, 2019
@lxbsz
logrotate: update the logdir path whenever it changes
f47cef9 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: gluster#199
Signed-off-by: Xiubo Li <[email protected]>
Reviewed-by: Prasanna Kumar Kalever <[email protected]>
pkalever pushed a commit that referenced this issue Apr 26, 2019
@lxbsz @pkalever
logrotate: update the logdir path whenever it changes
5b81651 
When the logDir is changed via the /etc/sysconfig/gluster-blockd
config file, the logrotate should be changed too.

Fixes: #199
Signed-off-by: Xiubo Li <[email protected]>
Reviewed-by: Prasanna Kumar Kalever <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkalever @lxbsz