Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hsb precision opacity #657

Closed
wants to merge 10 commits into from

Conversation

leewyatt
Copy link
Contributor

@leewyatt leewyatt commented Oct 3, 2023

PR Summary:
This PR addresses the issue where adjusting the opacity of a selected color in SceneBuilder results in unintended changes in its RGB values. This is due to inadequate precision of the HSB color representation.

Issue

Fixes #655

Progress

@abhinayagarwal abhinayagarwal changed the title Fix hsb precision opacity fix: hsb precision opacity Oct 24, 2023
@abhinayagarwal
Copy link
Collaborator

The representation of these properties is in Integer to the users of Scene Builder. I am not sure if converting it to double is the best solution.

@leewyatt
Copy link
Contributor Author

@abhinayagarwal Thank you for your insightful feedback regarding the PR. I understand your concerns about changing the data representation from Integer to Double for the color properties in Scene Builder, and how this might not align with the user experience and the current UI design.

I respect your perspective and agree that maintaining consistency and user friendliness is crucial. I’m open to discussing this further or exploring alternative approaches that could address the opacity adjustment issue without altering the core data types presented to the users.

Given your feedback, I suggest we could close this PR for now. I am more than willing to work on refining the solution based on our discussion and any additional guidance you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inadequate HSB Precision Causes RGB Values to Change When Adjusting Opacity
3 participants