-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hsb precision opacity #657
Conversation
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
…tionally altered because of the insufficient precision of the HSB representation.
The representation of these properties is in Integer to the users of Scene Builder. I am not sure if converting it to double is the best solution. |
@abhinayagarwal Thank you for your insightful feedback regarding the PR. I understand your concerns about changing the data representation from Integer to Double for the color properties in Scene Builder, and how this might not align with the user experience and the current UI design. I respect your perspective and agree that maintaining consistency and user friendliness is crucial. I’m open to discussing this further or exploring alternative approaches that could address the opacity adjustment issue without altering the core data types presented to the users. Given your feedback, I suggest we could close this PR for now. I am more than willing to work on refining the solution based on our discussion and any additional guidance you might have. |
PR Summary:
This PR addresses the issue where adjusting the opacity of a selected color in SceneBuilder results in unintended changes in its RGB values. This is due to inadequate precision of the HSB color representation.
Issue
Fixes #655
Progress