feat: ESC key selects parent of selected node #389
Conversation
abhinayagarwal
changed the title
|
@abhinayagarwal any news on this? |
AlmasB
changed the title
| @@ -85,6 +88,22 @@ protected void initializePanel() { | |||
| // We do not use the platform editing feature because | |||
| // editing is started on selection + simple click instead of double click | |||
| treeView.setEditable(false); | |||
|
|
|||
| treeView.setOnKeyPressed(event -> { | |||
There was a problem hiding this comment.
Is there any reason for why this is setOnKeyPressed() and the other change is addEventFilter()?
There was a problem hiding this comment.
Hello, sorry, I did not receive any mail about your comment. Let me check in the next days.
There was a problem hiding this comment.
@AlmasB changed to always call setOnKerPressed()
There was a problem hiding this comment.
Technically this looks okay for me.
There was a problem hiding this comment.
Please update first license header line in in ContentPanelController.java from * Copyright (c) 2016, 2018 Gluon and/or its affiliates. to * Copyright (c) 2016, 2022 Gluon and/or its affiliates..
Also please add the line * Copyright (c) 2022 Gluon and/or its affiliates. as new first line in HierarchyTreeViewController.java.
| @@ -85,6 +88,22 @@ protected void initializePanel() { | |||
| // We do not use the platform editing feature because | |||
| // editing is started on selection + simple click instead of double click | |||
| treeView.setEditable(false); | |||
|
|
|||
| treeView.setOnKeyPressed(event -> { | |||
There was a problem hiding this comment.
Technically this looks okay for me.
|
Hi @luca-domenichini , |
|
@Oliver-Loeffler done |
This PR implements #388.
Pressing ESC key selects the parent of the currently selected node.