-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: drop runtime dependency on pkg_resources (setuptools) #2365
Conversation
ac9ff87
to
ef7cc40
Compare
ef7cc40
to
6bcde3b
Compare
@@ -8,7 +8,6 @@ classifiers = | |||
Operating System :: OS Independent | |||
Programming Language :: Python | |||
Programming Language :: Python :: 3 | |||
Programming Language :: Python :: 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw python_requires = >=3.8
a few lines down, which is why I'm cleaning this marker while I'm in there
I think all failures are unrelated and were already seen in previously merged PRs, so I'll open this for review |
@astrofrog, anything else I can do here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@neutrinoceros this PR has introduced a failure on Unfortunately this was missed among all the very verbose python_exporter failures that are still under review.
Yet the test is passing locally with any of setuptools 66.0.0, 67.4.0 or 67.6.0. Any ideas? |
sorry about that, and thank you for pointing it out. I will dig into this ! |
I am able to reproduce the error locally (on Python 3.9.15), however I don't yet understand what is happening. Here are my notes at this point The Python 3.11 ships with |
Thanks; I still don't see the error locally after updating to either |
I had it backwards ! So I assumed that |
Description
resolves #2364
I left one call to
pkg_resources.get_distribution
indoc/conf
because I don't know how to replace it without requiringglue
be installed to build docs, and anyway it's not an issue for downstream code.