Accept component.units=None in translators input
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.12% // Head: 97.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 18 18
Lines 1324 1324
=======================================
Hits 1286 1286
Misses 38 38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@dhomeier could you do a new release of glue-astronomy with this fix once merged? |
|
Yes; leave glue-core dev in the tests? |
|
Yep! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix support for glue-viz/glue#2296.
Other uses of
component.unitsin the translators (NDDataArray,StdDevUncertainty) already acceptunit=None, so it seems most sensible to switch to theu.Quantity()format here.Added glue to devdeps to test this (might be a good idea in general?)