Skip to content

Fix CSV schema export #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

Fix CSV schema export #6

merged 3 commits into from
Mar 28, 2025

Conversation

cmcouto-silva
Copy link
Member

@cmcouto-silva cmcouto-silva commented Mar 27, 2025 •
edited
Loading

Fixed database schema export by:

  • Removing a call to the nonexistent method get_schema_df().
  • Adding support to schemas and moving the function to SQLBaseConnector.

@cmcouto-silva cmcouto-silva added the bug Something isn't working label Mar 27, 2025
@cmcouto-silva cmcouto-silva self-assigned this Mar 27, 2025
christiemj09
christiemj09 requested changes Mar 27, 2025
View reviewed changes
Copy link

@christiemj09 christiemj09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! A few updates to the PR description and the docs, and perhaps also updating tests to account for the new functionality added to export_schema_csv().

@cmcouto-silva
Copy link
Member Author

Thanks for catching this! A few updates to the PR description and the docs, and perhaps also updating tests to account for the new functionality added to export_schema_csv().

Done (expect unit tests, which will come on the next major PR)!

christiemj09
christiemj09 approved these changes Mar 28, 2025
View reviewed changes
Copy link

@christiemj09 christiemj09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those comments! Everything looks good now, feel free to merge 🚢

@cmcouto-silva cmcouto-silva merged commit 1c2d54f into main Mar 28, 2025
13 checks passed
@cmcouto-silva cmcouto-silva mentioned this pull request Mar 28, 2025
Closed
cmcouto-silva added a commit to cmcouto-silva/sqldeps that referenced this pull request Apr 3, 2025
@cmcouto-silva
Merge pull request glue-lab#6 from glue-lab/4-fix-postgresql-schema-e…
2341ee2 
…xport

Fix CSV schema export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiemj09 christiemj09 christiemj09 approved these changes

Assignees

@cmcouto-silva cmcouto-silva

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcouto-silva @christiemj09