Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semver violating change in gltf-json v1.2 #380

Closed
alice-i-cecile opened this issue Jun 8, 2023 · 3 comments
Closed

Semver violating change in gltf-json v1.2 #380

alice-i-cecile opened this issue Jun 8, 2023 · 3 comments

Comments

@alice-i-cecile
Copy link

This appears to have broken fresh builds of Bevy: see this CI run for an example.
@alteous
Copy link
Member

alteous commented Jun 8, 2023

Thanks for reporting. For a long time the gltf-* crates have been published in lock-step with each other. The semver guarantee really only applied to the top-level gltf crate. This was discussed in #241 a long time ago. The consensus of that issue was to make the other crates have proper semantic versioning but obviously that never happened.

In your run it looks like the problem is you are building both gltf 1.1 and 1.2, I imagine for export.

Compiling gltf-json v1.2.0
Compiling gltf v1.1.0

@alice-i-cecile
Copy link
Author

Okay, useful background! We'll take a look and see what we can do.

@alice-i-cecile
Copy link
Author

We can no longer reproduce this locally or in CI: maybe a caching issue. Anyways, I'll close this out: thanks for the help!

kpreid added a commit to kpreid/all-is-cubes that referenced this issue Jun 12, 2023
@kpreid
Update gltf + gltf-json dependency to 1.2.0.
e2cf24b 
The bad news: gltf-json made a semver-violating change
<gltf-rs/gltf#380> which breaks our build.

The good news: by depending on the newer version, we can get rid of
the horrible `HashMap` determinism kludge, because determinism via
using `BTreeMap` is the breaking change they made.
@alteous alteous mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @alteous