Fix user_dn_hash reconciliation when user DN contains special chars
#16806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cedric-anne
force-pushed
the
10.0/fix-user_dn_hash
branch
from
832ec71 to
a60fd3b
Compare
trasher
approved these changes
Mar 19, 2024
orthagh
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it has been introduced in #16096
user_dn_hashwas computed based onuser_dnvalues stored in DB, and these values are sanitized. The problem is that it is compared with a non-sanitized values, at least in the LDAP synchronization command.For instance,
md5('user=me,dc=R&D,dc=glpi-project,dc=org')does not match
md5('user=me,dc=R&D,dc=glpi-project,dc=org')