Replace alpine by debian for GLPI CI images
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
task/replace-alpine-by-debian
branch
from
14a0a68 to
5231e0c
Compare
|
Validated IRL by @orthagh . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #116.
cypresscannot be executed onalpineimages, as some required system packages are not available onalpine. See cypress-io/cypress#419.Executing the existing tests on an
alpinebased image and the newcypresstests on adebianbased image, as proposed in #116 and glpi-project/glpi#16373 will require to fetch both of them in our test suite and will require to maintain both of them. I think it is preferable to switch all of our test suite to adebianbased image, even if this image will be bigger.Please note that the CI will fail for the
githubactions-php-coverageand thegithubactions-glpibecause they will still try to be build using the previous image. This will be fixed once merged.