Add more descriptive error if sp and id are not provided

[cbkerr]

Description

Adds a better error messgae for calling project.open_job().

Motivation and Context

Before, it would tell you something that implied you provided both statepoint and id: "Either statepoint or id must be provided, but not both."

I was working on something for dashboard and this more descriptive message would have saved me a little time.

Checklist:

• I am familiar with the Contributing Guidelines.
• I agree with the terms of the Contributor Agreement.
• My name is on the list of contributors.
• The changes introduced by this pull request are covered by existing or newly introduced tests.
• The package documentation and framework documentation in signac-docs are up to date with these changes.
• I have updated the changelog and added any related issue and pull request numbers for future reference.

[codecov]

Codecov Report

Merging #915 (ac75665) into main (522944a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   86.64%   86.65%           
=======================================
  Files          41       41           
  Lines        4575     4577    +2     
  Branches      996      997    +1     
=======================================
+ Hits         3964     3966    +2     
  Misses        431      431           
  Partials      180      180           

Impacted Files	Coverage Δ
signac/project.py	86.51% <100.00%> (+0.04%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mikemhenry]

I am in favor of improving this error message, but I am not sure if id_none = id is None is something I understand that well. I would rather see the None checks directly then aliasing them like that personally. I could be easily persuaded (other examples of us doing this in the codebase? Is this the pythonic way?).

[cbkerr]

I am in favor of improving this error message, but I am not sure if id_none = id is None is something I understand that well. I would rather see the None checks directly then aliasing them like that personally. I could be easily persuaded (other examples of us doing this in the codebase? Is this the pythonic way?).

I defined the variables id_none and statepoint_none to only check the is once. But I didn't benchmark if that actually improves performance

[bdice]

I defined the variables id_none and statepoint_none to only check the is once. But I didn't benchmark if that actually improves performance

It is very unlikely that this will improve performance, in my estimation. x is None is a very cheap check. Let's aim for readability and check is None explicitly. I'll push a commit for that.

[bdice]

@cbkerr @mikemhenry I'm happy with the changes I just pushed. If you're happy with it, feel free to approve/merge.